This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(quality): add journeydoc-capture job (Playwright docs-screenshots)#107
Open
WilcoLouwerse wants to merge 1 commit into
Open
feat(quality): add journeydoc-capture job (Playwright docs-screenshots)#107WilcoLouwerse wants to merge 1 commit into
WilcoLouwerse wants to merge 1 commit into
Conversation
Per hydra#279, stap 14 — fleet-brede ondersteuning voor de journeydoc- pattern uit ADR-030 in de centrale quality workflow. Apps die de journeydoc-scaffold gebruiken kunnen nu nightly screenshots laten verversen zonder eigen workflow-code te schrijven. ### Wat dit doet Nieuwe `journeydoc-capture` job in Stage 2 van de reusable quality workflow: - Spint Nextcloud + Postgres + Playwright + chromium op (zelfde pattern als de bestaande `playwright` job) - Draait expliciet `npx playwright test --project docs-capture` — dus alleen `tests/e2e/docs-screenshots.spec.ts`, niet de regression - Vergelijkt `docs/static/screenshots/tutorials/` met HEAD - Committeert + pusht alleen wijzigingen terug naar de caller-branch (zelfde graceful-push pattern als features-extract/update-baseline, non-blocking op protected branches per #61) - Triggert optioneel een docs-deploy workflow via `gh workflow run` ### Geen PATs nodig Conform Conduction post-"github has been hacked" beleid: alleen `GITHUB_TOKEN` (contents:write + actions:write op job-niveau). ### Drie nieuwe inputs - `enable-journeydoc-capture` (bool, default false) — gate - `journeydoc-output-path` (string, default `docs/static/screenshots/tutorials`) — wat de commit-stap monitort - `journeydoc-deploy-workflow` (string, default empty) — optioneel workflow_dispatch-target na succesvolle commit ### Aanbevolen invocation-pattern Per-app een aparte `.github/workflows/docs-capture.yml`: on: schedule: - cron: "27 3 * * *" # nightly workflow_dispatch: jobs: capture: uses: ConductionNL/.github/.github/workflows/quality.yml@main with: app-name: <slug> enable-journeydoc-capture: true enable-frontend: false enable-license-check: false enable-sbom: false enable-features-extract: false journeydoc-deploy-workflow: documentation.yml Niet in code-quality.yml inschakelen (te duur voor elke PR). ### Validation YAML parses clean (python yaml.safe_load). 14 jobs totaal. Follow-up: - report-job's Quality Report tabel uitbreiden met een rij voor journeydoc-capture (cosmetic, ontbreekt nu) - Per-app `docs-capture.yml` workflow toevoegen aan de 7 apps die de journeydoc-scaffold al hebben (mydash, opencatalogi, openregister, openconnector, doriath, docudesk, pipelinq) — apart issue/PR per app Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per hydra#279 stap 14 — fleet-brede ondersteuning voor de journeydoc-pattern uit ADR-030 in de centrale quality workflow. Apps die de journeydoc-scaffold gebruiken (7 op dit moment: mydash, opencatalogi, openregister, openconnector, doriath, docudesk, pipelinq) kunnen nu nachtelijke screenshot-refresh inschakelen zonder eigen Nextcloud/Playwright-infra te schrijven.
Wat dit doet
Nieuwe
journeydoc-capturejob in Stage 2 vanquality.yml:playwrightjob)npx playwright test --project docs-capture— alleentests/e2e/docs-screenshots.spec.ts, niet de regressiondocs/static/screenshots/tutorials/met HEADfeatures-extract/update-baseline, non-blocking op protected branches per Allow CI bot to push auto-generated files (.coverage-baseline, SBOM) to ruleset-protected branches #61)gh workflow runGeen PATs nodig
Conform Conduction post-"github has been hacked" beleid: alleen
GITHUB_TOKEN(contents:write + actions:write op job-niveau).Nieuwe inputs
enable-journeydoc-capturefalsetrueom de job te activerenjourneydoc-output-pathdocs/static/screenshots/tutorialsjourneydoc-deploy-workflow""(leeg)documentation.yml) na succesvolle commitRecommended caller-pattern
Per-app aparte workflow (niet in de standaard
code-quality.ymlmengen — te duur voor elke PR):Validatie
Test plan
Follow-up (out of scope voor deze PR)
reportjob's Quality Report tabel uitbreiden met een rij voor journeydoc-capture (cosmetic; ontbreekt nu)docs-capture.ymlcompanion PRs voor mydash/openregister/openconnector/doriath/docudesk/pipelinqRefs hydra#279, ADR-030.
🤖 Generated with Claude Code